[PATCH] D32975: Make it illegal for two Functions to point to the same DISubprogram

[Keno Fischer via Phabricator via llvm-commits]

loladiro added a comment.

I'm really confused by the entirety of the changes to the CloneFunction parts of this. The whole point of the ValueMapper is to fix up value/metadata references. Why do we need a manual version? Also what's up with the `DISubprogram::getDistinct`? The ValueMapper will create new distinct  nodes as it goes along unless `RF_MoveDistinctMDs` is set (which it isn't inside CloneFunction). Could the problem perhaps have been an incorrectly unset `ModuleLevelChanges` flag? I'm seeing a ton of assertion failures after this change. I'll submit an appropriate PR to revert the CloneFunction parts of this.


Repository:
  rL LLVM

https://reviews.llvm.org/D32975