[PATCH] D33635: [libcxxabi] rework CMakeLists.txt into modules

[Martell Malone via Phabricator via llvm-commits]

martell added inline comments.


================
Comment at: CMakeLists.txt:325
-if (WIN32 AND LIBCXXABI_ENABLE_STATIC AND NOT LIBCXXABI_ENABLE_SHARED)
-  add_definitions(-D_LIBCXXABI_DISABLE_DLL_IMPORT_EXPORT)
-endif()
----------------
martell wrote:
> Just a note here. This doesn't do anything since rL288692 so removing it here.
> I have put together a patch to enable different options for static and shared builds when they are both requested in the one cmake run so I will add that in a follow up differential.
I fixed this in rL304110.
Will update without removing this block for now to make this commit cleaner


Repository:
  rL LLVM

https://reviews.llvm.org/D33635