[PATCH] D33404: [PowerPC] Fix a performance bug for PPC::XXPERMDI.

[Tony Jiang via Phabricator via llvm-commits]

jtony marked 2 inline comments as done.
jtony added inline comments.


================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:1772
+bool PPC::isXXPERMDIShuffleMask(ShuffleVectorSDNode *N, unsigned &DM,
+                               bool &Swap, bool IsLE) {
+  assert(N->getValueType(0) == MVT::v16i8 && "Shuffle vector expects v16i8");
----------------
echristo wrote:
> Since this is basically two functions concatenated on each other with a boolean parameter it seems reasonable to just remove the parameter and split it into two functions and dispatch in the caller.
> 
> Or do it as a followup with the rest of them, but either way it'd be good to get the endianness stuff cleaned up.
This can be done together with the same issue created for the xxsldwi patch.



https://reviews.llvm.org/D33404