[PATCH] D33635: [libcxxabi] rework CMakeLists.txt into modules

Martell Malone via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 28 12:29:03 PDT 2017


martell created this revision.
Herald added a subscriber: mgorny.

libcxxabi was having issues with detecting flags in `config-ix.cmake`correctly when cross compiling.
I narrowed it down to changes as a result of including

  list(APPEND CMAKE_MODULE_PATH "${LLVM_CMAKE_PATH}")
  include("${LLVM_CMAKE_PATH}/AddLLVM.cmake")
  include("${LLVM_CMAKE_PATH}/HandleLLVMOptions.cmake")

The best way to solve this was to rework CMake to use modules to mirror libcxx.
This makes the cmake source more readable and maintainable


Repository:
  rL LLVM

https://reviews.llvm.org/D33635

Files:
  CMakeLists.txt
  cmake/Modules/HandleLibcxxabiFlags.cmake
  cmake/Modules/HandleOutOfTreeLLVM.cmake
  cmake/Modules/MacroEnsureOutOfSourceBuild.cmake
  src/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33635.100560.patch
Type: text/x-patch
Size: 28180 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170528/cf69ff40/attachment.bin>


More information about the llvm-commits mailing list