[PATCH] D33404: [PowerPC] Fix a performance bug for PPC::XXPERMDI.

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added inline comments.


================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:1606
+  unsigned NumOfElem = 16 / Width;
+  unsigned *MaskVal = new unsigned[Width];
+  for (unsigned i = 0; i < NumOfElem; ++i) {
----------------
Is there a compelling reason to manually allocate memory for this over using efficient containers (something like `SmallVector` or similar)?

I'd much rather avoid manual memory management of this sort if we can. And I don't see anything in this function to indicate we can't.


https://reviews.llvm.org/D33404