[PATCH] D33614: Cloning: Fix debug info cloning
Gor Nishanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 26 20:08:37 PDT 2017
GorNishanov added inline comments.
================
Comment at: lib/IR/DebugLoc.cpp:170
+
+ auto *NewVar = DILocalVariable::get(
+ Ctx,
----------------
dblaikie wrote:
> Is there a reason this can't be distinct anymore?
>
> You mentioned in the description: "I added caching, but, it is not sufficient, since dbg.value may refer to various expressions representing the same user var, thus, switching form getDistinct to get is important."
>
> But I don't follow quite what you're saying there - could you explain it in more detail/in another way?
>
> What happens without changing this to 'get'?
It can still creates duplicate DILocalVariables. I have it in the very large test case, I can see if I can reduce it to something manangable. Thank you for looking at this!
https://reviews.llvm.org/D33614
More information about the llvm-commits
mailing list