[PATCH] D33540: [PM/ThinLTO] Port the ThinLTO pipeline (both components) to the new PM.

[Eric Christopher via Phabricator via llvm-commits]

echristo added a comment.

In https://reviews.llvm.org/D33540#766418, @chandlerc wrote:

> (FYI, I think this is ready for another look, only outstanding issue I'm aware of is Mehdi's concern around 'pre-link' terminology and that really just needs anyone else with naming thoughts to chime in...)


FWIW I like both the name and the consistency...

I've also taken a quick look and other than a complaint about boolean parameters it looks ok to me.



================
Comment at: lib/LTO/LTOBackend.cpp:140
+static void runNewPMPasses(Module &Mod, TargetMachine *TM, unsigned OptLevel,
+                           bool IsThinLTO) {
   PassBuilder PB(TM);
----------------
Boolean arguments are terrible. I don't have any better ideas at the moment that don't involve wide refactoring though.


https://reviews.llvm.org/D33540