[PATCH] D33488: [ELF] - Optimization for populating stringpool when building .gdb_index.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Fri May 26 11:16:24 PDT 2017


George Rimar <grimar at accesssoftek.com> writes:

> hash uses tolower() starting from 5 version of index (https://sourceware.org/gdb/onlinedocs/gdb/Index-Section-Format.html).
> Doc says: "The names of C++ symbols in the hash table are canonicalized. We don’t currently have a simple description of the
> canonicalization algorithm; if you intend to create new index sections, you must read the code."
>
> Since our index looks work fine, I did not think about what is "canonicalization" here, assuming we are ok atm. 
> That may need investigation probably.

Yes, if we can just assert in the hash that all theh letters are
lowercase that would be good.

Cheers,
Rafael


More information about the llvm-commits mailing list