[PATCH] D30107: Refactor DynamicLibrary so searching for a symbol will have a defined order and libraries are properly unloaded when llvm_shutdown is called.

Frederich Munch via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 26 09:51:33 PDT 2017


marsupial added a comment.

It did neither (1) or (2) before, because the order the handles were stored was not **defined**.
This was particularly noticeable on Windows due to how it uses shim libs for runtime functions.
I assume you guys aren't arguing to going back to undefined behavior just because it worked better for you.

This patch explicitly states that symbol lookup is now done in the following order:
Process,
Libraries loaded from OS linker at runtime.
Libraries loaded from user at runtime.

How is this bad overall or in your use case in particular?


Repository:
  rL LLVM

https://reviews.llvm.org/D30107





More information about the llvm-commits mailing list