[PATCH] D33548: [DWARF] - Cleanup relocation handling.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: include/llvm/Object/RelocVisitor.h:62
+                                            uint64_t Value);
+  Visitor Vis;
+
----------------
grimar wrote:
> ruiu wrote:
> > Why don't you use std::function?
> I am pretty sure I was asked by somebody to use poiner in one of reviews earlier, do not really remember why, so
> I supposed it is preferred in LLVM before your comment, though it looks std::function is used widely. So I can switch to it.
Well, maybe a bare pointer is smaller and faster than std::function, I guess? I'd guess David Blaikie knows more than me about that.


https://reviews.llvm.org/D33548