[PATCH] D32399: [LLD] Order writable executable sections before writable ones

[Mark Kettenis via llvm-commits]

> From: Rafael Avila de Espindola <rafael.espindola at gmail.com>
> Date: Wed, 24 May 2017 09:24:26 -0700
> 
> LGTM too.
> 
> Mark, do you have commit access?

No I don't.  Would be great if one of you culd commit this for me.  or
perhaps arrange commit access for me; I have a few more diffs coming
;).

> Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:
> 
> > ruiu accepted this revision.
> > ruiu added a comment.
> > This revision is now accepted and ready to land.
> >
> > LGTM
> >
> >
> >
> > ================
> > Comment at: lld/ELF/Writer.cpp:637
> > +  RF_NOT_ALLOC = 1 << 14,
> > +  RF_WRITE = 1 << 13,
> > +  RF_EXEC_WRITE = 1 << 12,
> > ----------------
> > nit: RF_WRITE_EXEC is probably more natural order, as in rwx.
> >
> >
> >
> > ================
> > Comment at: lld/ELF/Writer.cpp:681
> > +  // * Writable, executable sections follow such that .plt on
> > +  //   architectures where it needs to be writable will be placed
> > +  //   between .text and .data.
> > ----------------
> > Add "(such as SPARC)" after "writable"
> >
> >
> > ================
> > Comment at: lld/ELF/Writer.cpp:693-694
> >        Rank |= RF_EXEC;
> > +  } else {
> > +    if (IsWrite)
> > +      Rank |= RF_WRITE;
> > ----------------
> > `} else if {`
> >
> >
> > https://reviews.llvm.org/D32399
>