[PATCH] D33380: Add a dominanance check interface that uses caching for instructions within same basic block.

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 26 08:00:00 PDT 2017


dberlin added inline comments.


================
Comment at: lib/Transforms/Utils/OrderedInstructions.cpp:22
+                                    const Instruction *InstB,
+                                    const DominatorTree *DT) {
+  const BasicBlock *IBB = InstA->getParent();
----------------
Can you just take the DT in the constructor?
That way i can fill in the rest of the DT use cases as functions, and not have to take dominatortree anywhere.



https://reviews.llvm.org/D33380





More information about the llvm-commits mailing list