[PATCH] D33569: [asan] Enable back some ASan tests disabled on PowerPC.

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL303995: [asan] Enable back some ASan tests disabled on PowerPC. (authored by alekseyshl).

Changed prior to commit:
  https://reviews.llvm.org/D33569?vs=100307&id=100409#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D33569

Files:
  compiler-rt/trunk/lib/asan/tests/asan_interface_test.cc
  compiler-rt/trunk/lib/asan/tests/asan_noinst_test.cc
  compiler-rt/trunk/test/asan/TestCases/Posix/current_allocated_bytes.cc


Index: compiler-rt/trunk/lib/asan/tests/asan_interface_test.cc
===================================================================
--- compiler-rt/trunk/lib/asan/tests/asan_interface_test.cc
+++ compiler-rt/trunk/lib/asan/tests/asan_interface_test.cc
@@ -102,9 +102,6 @@
   }
 }
 
-#ifndef __powerpc64__
-// FIXME: This has not reliably worked on powerpc since r279664.  Re-enable
-// this once the problem is tracked down and fixed.
 static const size_t kManyThreadsMallocSizes[] = {5, 1UL<<10, 1UL<<14, 357};
 static const size_t kManyThreadsIterations = 250;
 static const size_t kManyThreadsNumThreads =
@@ -138,7 +135,6 @@
   // so we can't check for equality here.
   EXPECT_LT(after_test, before_test + (1UL<<20));
 }
-#endif
 
 static void DoDoubleFree() {
   int *x = Ident(new int);
Index: compiler-rt/trunk/lib/asan/tests/asan_noinst_test.cc
===================================================================
--- compiler-rt/trunk/lib/asan/tests/asan_noinst_test.cc
+++ compiler-rt/trunk/lib/asan/tests/asan_noinst_test.cc
@@ -97,9 +97,6 @@
   MallocStress(ASAN_LOW_MEMORY ? 300000 : 1000000);
 }
 
-#ifndef __powerpc64__
-// FIXME: This has not reliably worked on powerpc since r279664.  Re-enable
-// this once the problem is tracked down and fixed.
 TEST(AddressSanitizer, ThreadedMallocStressTest) {
   const int kNumThreads = 4;
   const int kNumIterations = (ASAN_LOW_MEMORY) ? 10000 : 100000;
@@ -112,7 +109,6 @@
     PTHREAD_JOIN(t[i], 0);
   }
 }
-#endif
 
 static void PrintShadow(const char *tag, uptr ptr, size_t size) {
   fprintf(stderr, "%s shadow: %lx size % 3ld: ", tag, (long)ptr, (long)size);
@@ -210,10 +206,6 @@
   return NULL;
 }
 
-#ifndef __powerpc64__
-// FIXME: This has not reliably worked on powerpc since r279664.  Re-enable
-// this once the problem is tracked down and fixed.
-
 TEST(AddressSanitizer, ThreadedOneSizeMallocStressTest) {
   const int kNumThreads = 4;
   pthread_t t[kNumThreads];
@@ -224,7 +216,6 @@
     PTHREAD_JOIN(t[i], 0);
   }
 }
-#endif
 
 TEST(AddressSanitizer, ShadowRegionIsPoisonedTest) {
   using __asan::kHighMemEnd;
Index: compiler-rt/trunk/test/asan/TestCases/Posix/current_allocated_bytes.cc
===================================================================
--- compiler-rt/trunk/test/asan/TestCases/Posix/current_allocated_bytes.cc
+++ compiler-rt/trunk/test/asan/TestCases/Posix/current_allocated_bytes.cc
@@ -1,9 +1,6 @@
 // RUN: %clangxx_asan -O0 %s -pthread -o %t && %run %t
 // RUN: %clangxx_asan -O2 %s -pthread -o %t && %run %t
 // REQUIRES: stable-runtime
-// UNSUPPORTED: powerpc64le
-// FIXME: This test occasionally fails on powerpc64 LE possibly starting with
-// r279664.  Re-enable the test once the problem(s) have been fixed.
 
 #include <assert.h>
 #include <pthread.h>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33569.100409.patch
Type: text/x-patch
Size: 2765 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170526/8359d1d8/attachment.bin>