[llvm] r303979 - Export the required symbol from DynamicLibraryTests

Roger Ferrer Ibanez via llvm-commits llvm-commits at lists.llvm.org
Fri May 26 05:51:12 PDT 2017


Author: rogfer01
Date: Fri May 26 07:51:12 2017
New Revision: 303979

URL: http://llvm.org/viewvc/llvm-project?rev=303979&view=rev
Log:
Export the required symbol from DynamicLibraryTests

Running unittests/Support/DynamicLibrary/DynamicLibraryTests fails when LLVM is
configured with LLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON, because the test's version
script only contains symbols extracted from the static libraries, that the test
links with, but not those from the main object/executable itself. The patch
explicitly exports the one symbol needed by the test.

This change fixes https://bugs.llvm.org/show_bug.cgi?id=32893

Patch authored by Momchil Velikov.

Differential Revision: https://reviews.llvm.org/D33490



Added:
    llvm/trunk/unittests/Support/DynamicLibrary/DynamicLibraryTests.exports
Modified:
    llvm/trunk/unittests/Support/DynamicLibrary/CMakeLists.txt

Modified: llvm/trunk/unittests/Support/DynamicLibrary/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/DynamicLibrary/CMakeLists.txt?rev=303979&r1=303978&r2=303979&view=diff
==============================================================================
--- llvm/trunk/unittests/Support/DynamicLibrary/CMakeLists.txt (original)
+++ llvm/trunk/unittests/Support/DynamicLibrary/CMakeLists.txt Fri May 26 07:51:12 2017
@@ -1,5 +1,6 @@
 set(LLVM_LINK_COMPONENTS Support)
 
+set(LLVM_EXPORTED_SYMBOL_FILE ${CMAKE_CURRENT_SOURCE_DIR}/DynamicLibraryTests.exports)
 add_llvm_unittest(DynamicLibraryTests DynamicLibraryTest.cpp)
 
 export_executable_symbols(DynamicLibraryTests)

Added: llvm/trunk/unittests/Support/DynamicLibrary/DynamicLibraryTests.exports
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/DynamicLibrary/DynamicLibraryTests.exports?rev=303979&view=auto
==============================================================================
--- llvm/trunk/unittests/Support/DynamicLibrary/DynamicLibraryTests.exports (added)
+++ llvm/trunk/unittests/Support/DynamicLibrary/DynamicLibraryTests.exports Fri May 26 07:51:12 2017
@@ -0,0 +1 @@
+TestA




More information about the llvm-commits mailing list