[PATCH] D33513: [ThinLTO] Fix ThinLTO crash while destroying context

[Peter Collingbourne via llvm-commits]

On Thu, May 25, 2017 at 5:03 PM, Mehdi AMINI via Phabricator <
reviews at reviews.llvm.org> wrote:

> mehdi_amini added a comment.
>
> In https://reviews.llvm.org/D33513#764629, @ncharlie wrote:
>
> > In https://reviews.llvm.org/D33513#763708, @davide wrote:
> >
> > > Thanks for your first contribution, great GSoC start!
> >
> >
> > Thanks! This was a good chance to look closely at the code to start
> learning how it works.
> >
> > > One note: this manifests with ThinLTO, but it might be a more generic
> metadata issue. Are you able to reproduce without ThinLTO  (and maybe with
> a single file?)
> >
> > The bug only happens when lazy loading Metadata. Lazy loading occurs
> when module level metadata is being imported by ThinLTO (see
> https://reviews.llvm.org/diffusion/L/browse/llvm/trunk/lib/Bitcode/Reader/
> MetadataLoader.cpp;303885$781). I believe this is the only path that
> leads to lazy loading, so I don't think it can happen elsewhere.
>
>
> If there is no other path to exercise LazyLoading of Metadata, let's just
> create one! (add an option to llvm-dis for example).
>

I believe that there already is one, -materialize-metadata.
-- 
-- 
Peter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170525/d14f8800/attachment.html>