[PATCH] D33575: [llvm-ar] Make llvm-lib behave more like the MSVC archiver

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 25 16:45:30 PDT 2017


rnk marked an inline comment as done.
rnk added inline comments.


================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:187
+static bool useStringTable(bool WriteObjPaths, StringRef Name) {
+  // Force the use of the string table if we're writing full paths.
+  return WriteObjPaths || Name.size() >= 16;
----------------
ruiu wrote:
> If it fits in 16 byte buffer, we can write there even if a path contains a path separator, no?
I don't think so. '/' seems to be a special character inside the short name.


https://reviews.llvm.org/D33575





More information about the llvm-commits mailing list