[PATCH] D32816: [CMake] Support multi-target runtimes build

[Jonathan Roelofs via Phabricator via llvm-commits]

jroelofs added inline comments.


================
Comment at: runtimes/CMakeLists.txt:314
+                                 # Builtins were built separately above
+                                 CMAKE_ARGS -DCOMPILER_RT_BUILD_BUILTINS=Off
+                                            -DLLVM_INCLUDE_TESTS=${LLVM_INCLUDE_TESTS}
----------------
aoli wrote:
> Shall we also pass CMAKE_BUILD_TYPE here?
@aoli making the runtimes have the same build type as the compiler? No. That should only be passed via `RUNTIMES_${target}_CMAKE_BUILD_TYPE=`


Repository:
  rL LLVM

https://reviews.llvm.org/D32816