[PATCH] D33519: [PPC] Lower llvm.ppc.cfence(constant) to no-op.

[Kit Barton via Phabricator via llvm-commits]

kbarton added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:8220
+      return Op.getOperand(0);
+    }
     assert(Subtarget.isPPC64() && "Only 64-bit is supported for now.");
----------------
I agree with this, but I'm wondering if it could/should be generalized a bit more. 
Are there other cases of SDNodes that we could reach here that are not valid? 
Alternatively, is it possible to enumerate the legal SD nodes that could be here and remove everything that is not legal? 


================
Comment at: llvm/test/CodeGen/PowerPC/atomics-constant.ll:4
+
+target triple = "powerpc64le-linux-gnu"
+
----------------
The triple we normally use is powerpc64le-unknown-linux-gnu. 


https://reviews.llvm.org/D33519