[PATCH] D32756: [DAGCombine] Refactor common addcarry pattern.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 25 14:32:20 PDT 2017


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

@filcab suggested adding the PR number on the commit message title as well.

LGTM - couple of minors.



================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2224
+    if (Y.getOpcode() == ISD::UADDO &&
+        CarryIn.getOpcode() == ISD::ADDCARRY &&
+        isNullConstant(CarryIn.getOperand(1)) &&
----------------
Worth checking/asserting that CarryIn.getResNo() == 1 ?


https://reviews.llvm.org/D32756





More information about the llvm-commits mailing list