[PATCH] D33564: [CodeView Type Merging] Make a Type Index Iterator that bypasses the visitor framework

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/CodeView/TypeRecord.h:288
+                PointerOptions PO, uint8_t Size,
+                TypeIndex MemberPtrContainingType)
       : TypeRecord(TypeRecordKind::Pointer), ReferentType(ReferentType),
----------------
zturner wrote:
> rnk wrote:
> > How is this new constructor used? It's reasonable to not force the caller to construct a MemberPointerInfo and instead take both the Class type index and the member pointer representation, but defaulting unknown seems error-prone.
> It's used in the unit test.
Got it, I searched for `PointerRecord(` and got no hits. I'd still prefer to make that constructor call build a MemberPointerInfo().


https://reviews.llvm.org/D33564