[PATCH] D33515: Fix the ManagedStatic list ordering when using DynamicLibrary::addPermanentLibrary.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 25 12:53:27 PDT 2017


efriedma added a comment.

> I'm not trying to pass the buck here, this has in fact lead to finding two interesting bugs, but it certainly seems there's an API misuse/deficiency that super-cedes this issue. Even if the ManagedStatic ordering is completely sorted out, how is Polly handling the valid is case of a user using llvm_shutdown. That is once llvm_shutdown has been GlobalExtensions will have been cleared and the passes no longer available.

That might be a problem...?  I'm not sure how people use llvm_shutdown in practice.  (For clang/opt/etc. this doesn't matter because we don't run any LLVM passes after the call to llvm_shutdown.)


https://reviews.llvm.org/D33515





More information about the llvm-commits mailing list