[PATCH] D33558: [AArch64]: add 'a' inline asm operand modifier.

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 25 11:49:18 PDT 2017


rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

Silly inline comment, but otherwise, LGTM. Thanks!



================
Comment at: lib/Target/AArch64/AArch64AsmPrinter.cpp:395
+  if (ExtraCode && ExtraCode[0]) {
+    if (ExtraCode[0] != 'a')
+      return true; // modifier other than 'a'.
----------------
why not:

    if (ExtraCode && ExtraCode[0] && ExtraCode[0] != 'a')
      return true;


https://reviews.llvm.org/D33558





More information about the llvm-commits mailing list