[PATCH] D28637: [PPC] Inline expansion of memcmp

Zaara Syeda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 25 06:40:51 PDT 2017


syzaara added inline comments.


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:2319
+
+unsigned MemCmpExpansion::getLoadSize(unsigned Size) {
+  unsigned LoadSize = MaxLoadSize;
----------------
efriedma wrote:
> `return MinAlign(Size, MaxLoadSize)`?
MinAlign doesn't work here. MinAlign returns the largest power of 2 that divides both Size and MaxLoadSize. We want the largest power of 2 which is <= Size.


https://reviews.llvm.org/D28637





More information about the llvm-commits mailing list