[PATCH] D33485: [ELF] - Do not allow -r to eat comdats.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu May 25 02:49:37 PDT 2017


>>  static uint64_t getOutFlags(InputSectionBase *S) {
>> +  if (Config->Relocatable)
>> +    return S->Flags & ~SHF_COMPRESSED;
>
>Not really related to the patch, but do we decompress in -r? Should we?
>Would you mind checking and opening a bug if needed?

Yeah, I also noticed that place is wierd when wrote patch, will check it soon.

>
>LGTM with a stronger test.
>

Thanks for review !

>Thanks,
>Rafael

George.


More information about the llvm-commits mailing list