[PATCH] D33528: [LegacyPM] Make the 'addLoop' method accept a loop to add rather than having it internally allocate the loop.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 19:56:44 PDT 2017


chandlerc marked an inline comment as done.
chandlerc added a comment.

Thanks, landing!

In https://reviews.llvm.org/D33528#763997, @davide wrote:

> This is fine assuming you audited all the callers (a quick grep shows just these two).


Yeah, my grep concludes the same.



================
Comment at: lib/Analysis/LoopPass.cpp:76
 
 // Inset loop into loop nest (LoopInfo) and loop queue (LQ).
+void LPPassManager::addLoop(Loop &L) {
----------------
davide wrote:
> this should be insert, I think, but it's not your fault.
I'll fix the typo while here.


https://reviews.llvm.org/D33528





More information about the llvm-commits mailing list