[PATCH] D33524: [coroutines] Allow rematerialization upto 4 times. Remove incorrect assert

[Gor Nishanov via Phabricator via llvm-commits]

GorNishanov added inline comments.


================
Comment at: lib/Transforms/Coroutines/CoroFrame.cpp:817
 
-  // See if there are materializable instructions across suspend points.
-  for (Instruction &I : instructions(F))
-    if (materializable(I))
-      for (User *U : I.users())
-        if (Checker.isDefinitionAcrossSuspend(I, U))
-          Spills.emplace_back(&I, U);
+  for (int repeat = 0; repeat < 4; ++repeat) {
+    // See if there are materializable instructions across suspend points.
----------------
GorNishanov wrote:
> majnemer wrote:
> > Please abide by the coding convention.
> I will be glad to. Can you clarify what coding convention you are referring to?
Got it. Sanjoy clarified that variables start with Capital letters.


Repository:
  rL LLVM

https://reviews.llvm.org/D33524