[PATCH] D32816: [CMake] Support multi-target runtimes build

Leo Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 17:43:48 PDT 2017


aoli added a comment.

Hi I did some tests about this patch and I got one question.

Due to `include(HandleLLVMOptions)` compiling runtimes will require libc++ for targets. And the test in cmake/modules/CheckCompilerVersion.cmake: 38 will fail. Since compiling compiler-rt does not require libc++ do we really need to include this file here? This not a problem for building runtimes for host because libc++ is always installed on hosts. But targets may not have libc++.


Repository:
  rL LLVM

https://reviews.llvm.org/D32816





More information about the llvm-commits mailing list