[PATCH] D33485: [ELF] - Do not allow -r to eat comdats.

[Rui Ueyama via llvm-commits]

On Wed, May 24, 2017 at 3:36 PM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:
>
> > ruiu added a comment.
> >
> > In general, I think we pass through all input sections to an output when
> the -r option is given. But in this patch you deduplicates comdat groups.
> Do you need that?
>
> While it should be legal to have two groups with the same signature in a .o
> file, it seems better to drop the second one, no?
>

Yes, but I wondered if we could make this patch simpler if we don't dedup
comdat groups.


> For what it is worth, both bfd and gold drop it.
>
> Taking a look at the patch.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170524/ecec68bc/attachment.html>