[PATCH] D33520: Garbage collect dllimported symbols.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

Can you construct a test case that shows that we handle weak externals correctly?



================
Comment at: lld/COFF/Writer.cpp:454
+  if (auto *Sym = dyn_cast<DefinedImportThunk>(Def))
+    if (!Sym->WrappedSym->File->Live)
+      return None;
----------------
I guess this means that we are not gc'ing unused thunks any more. But I guess this isn't a regression, so it seems fine to me.


https://reviews.llvm.org/D33520