[PATCH] D32669: [Nios2] Target registration

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/Nios2/LLVMBuild.txt:1
+;===- ./lib/Target/Nios2/LLVMBuild.txt --------------------------*- Conf -*--===;
+;
----------------
80 columns. I think the first line of many of your files are too long.


================
Comment at: llvm/lib/Target/Nios2/Nios2InstrFormats.td:40
+  bits<6> Opcode = 0;
+  bits<6> OpxH = 0;
+  bits<5> shamt = 0;
----------------
Are the OpxH and shamt fields used?


================
Comment at: llvm/lib/Target/Nios2/Nios2InstrFormats.td:97
+  bits<5> rC;
+  bits<11> opx;
+
----------------
Is this unused?


https://reviews.llvm.org/D32669