[PATCH] D33471: [asan] Remove allow_user_segv_handler on Windows.

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Either this or the reland of making allow_user_segv_handler to true broke this test on Windows:

  lit.py: E:/b/build/slave/win_upload_clang/build/src/third_party/llvm/tools/clang/test/lit.cfg:200: note: using clang: 'E:/b/build/slave/win_upload_clang/build/src/third_party/llvm-bootstrap/./bin/clang.EXE'
  -- Testing: 33069 tests, 8 threads --
  Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.
  FAIL: UBSan-Standalone-x86_64 :: TestCases/Integer/negate-overflow.cpp (31844 of 33069)
  ******************** TEST 'UBSan-Standalone-x86_64 :: TestCases/Integer/negate-overflow.cpp' FAILED ********************
  Script:
  --
  E:/b/build/slave/win_upload_clang/build/src/third_party/llvm-bootstrap/./bin/clang.exe  -fms-compatibility-version=19.00.24213.1 -fsanitize=signed-integer-overflow E:\b\build\slave\win_upload_clang\build\src\third_party\llvm\projects\compiler-rt\test\ubsan\TestCases\Integer\negate-overflow.cpp -o E:\b\build\slave\win_upload_clang\build\src\third_party\llvm-bootstrap\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Integer\Output\negate-overflow.cpp.tmp1 &&  E:\b\build\slave\win_upload_clang\build\src\third_party\llvm-bootstrap\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Integer\Output\negate-overflow.cpp.tmp1 2>&1 | FileCheck E:\b\build\slave\win_upload_clang\build\src\third_party\llvm\projects\compiler-rt\test\ubsan\TestCases\Integer\negate-overflow.cpp --check-prefix=CHECKS
  E:/b/build/slave/win_upload_clang/build/src/third_party/llvm-bootstrap/./bin/clang.exe  -fms-compatibility-version=19.00.24213.1 -fsanitize=unsigned-integer-overflow E:\b\build\slave\win_upload_clang\build\src\third_party\llvm\projects\compiler-rt\test\ubsan\TestCases\Integer\negate-overflow.cpp -o E:\b\build\slave\win_upload_clang\build\src\third_party\llvm-bootstrap\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Integer\Output\negate-overflow.cpp.tmp2 &&  E:\b\build\slave\win_upload_clang\build\src\third_party\llvm-bootstrap\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Integer\Output\negate-overflow.cpp.tmp2 2>&1 | FileCheck E:\b\build\slave\win_upload_clang\build\src\third_party\llvm\projects\compiler-rt\test\ubsan\TestCases\Integer\negate-overflow.cpp --check-prefix=CHECKU
  --
  Exit Code: -2147483648
  Command Output (stdout):
  --
  $ "E:/b/build/slave/win_upload_clang/build/src/third_party/llvm-bootstrap/./bin/clang.exe" "-fms-compatibility-version=19.00.24213.1" "-fsanitize=signed-integer-overflow" "E:\b\build\slave\win_upload_clang\build\src\third_party\llvm\projects\compiler-rt\test\ubsan\TestCases\Integer\negate-overflow.cpp" "-o" "E:\b\build\slave\win_upload_clang\build\src\third_party\llvm-bootstrap\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Integer\Output\negate-overflow.cpp.tmp1"
  # command output:
     Creating library E:\b\build\slave\win_upload_clang\build\src\third_party\llvm-bootstrap\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Integer\Output\negate-overflow.cpp.lib and object E:\b\build\slave\win_upload_clang\build\src\third_party\llvm-bootstrap\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Integer\Output\negate-overflow.cpp.exp
  # command stderr:
  E:\b\build\slave\win_upload_clang\build\src\third_party\llvm\projects\compiler-rt\test\ubsan\TestCases\Integer\negate-overflow.cpp:8:3: warning: expression result unused [-Wunused-value]
    -unsigned(-0x7fffffff - 1); // ok
    ^~~~~~~~~~~~~~~~~~~~~~~~~~
  1 warning generated.
  $ "E:\b\build\slave\win_upload_clang\build\src\third_party\llvm-bootstrap\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Integer\Output\negate-overflow.cpp.tmp1"
  note: command had no output on stdout or stderr
  error: command failed with exit status: 0x80000000
  $ "FileCheck" "E:\b\build\slave\win_upload_clang\build\src\third_party\llvm\projects\compiler-rt\test\ubsan\TestCases\Integer\negate-overflow.cpp" "--check-prefix=CHECKS"
  --

Please take a look, and if it takes more than an hour to fix, please revert in the meantime.

(https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin_upload_clang%2F186%2F%2B%2Frecipes%2Fsteps%2Fpackage_clang%2F0%2Fstdout)


Repository:
  rL LLVM

https://reviews.llvm.org/D33471