[PATCH] D33475: [pdb] pad source file name buffer at the end instead of the beginning

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 09:20:27 PDT 2017


zturner added a comment.

In https://reviews.llvm.org/D33475#763306, @amccarth wrote:

> I'm slightly confused by the summary.  This patch changes where the names are written to.  How do we know that right versus changing where the names are read from?


Hmm, you raise a good point.  Bob, can you take a look at `DBI1::reloadFileInfo` in `dbi.cpp` in the reference implementation?  I looked at it briefly and it does not appear to align the beginning of the names buffer, but it does align the size of the entire file info substream.


https://reviews.llvm.org/D33475





More information about the llvm-commits mailing list