[PATCH] D33431: [ValueTracking] Convert most of the calls to computeKnownBits to use the version that returns the KnownBits obje

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 08:17:47 PDT 2017


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM - the KnownBits changes and the OptimizationRemarkEmitter arg change should be committed separately.



================
Comment at: include/llvm/Analysis/ValueTracking.h:64
+                             const DominatorTree *DT = nullptr,
+                             OptimizationRemarkEmitter *ORE = nullptr);
   /// Compute known bits from the range metadata.
----------------
This looks like it should be committed separately but I don't know what test coverage is possible.


https://reviews.llvm.org/D33431





More information about the llvm-commits mailing list