[compiler-rt] r303728 - [asan] Remove allow_user_segv_handler on Windows.

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 00:17:27 PDT 2017


Author: vitalybuka
Date: Wed May 24 02:17:27 2017
New Revision: 303728

URL: http://llvm.org/viewvc/llvm-project?rev=303728&view=rev
Log:
[asan] Remove allow_user_segv_handler on Windows.

Summary:
This flags is not covered by tests on Windows and looks like it's implemented
incorrectly. Switching its default breaks some tests.

Taking into account that related handle_segv flag is not supported on Windows
it's safer to remove it until we commit to support it.

Reviewers: eugenis, zturner, rnk

Subscribers: kubamracek, llvm-commits

Differential Revision: https://reviews.llvm.org/D33471

Modified:
    compiler-rt/trunk/lib/asan/asan_win.cc

Modified: compiler-rt/trunk/lib/asan/asan_win.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_win.cc?rev=303728&r1=303727&r2=303728&view=diff
==============================================================================
--- compiler-rt/trunk/lib/asan/asan_win.cc (original)
+++ compiler-rt/trunk/lib/asan/asan_win.cc Wed May 24 02:17:27 2017
@@ -80,7 +80,7 @@ static long WINAPI SEHHandler(EXCEPTION_
 INTERCEPTOR_WINAPI(LPTOP_LEVEL_EXCEPTION_FILTER, SetUnhandledExceptionFilter,
     LPTOP_LEVEL_EXCEPTION_FILTER ExceptionFilter) {
   CHECK(REAL(SetUnhandledExceptionFilter));
-  if (ExceptionFilter == &SEHHandler || common_flags()->allow_user_segv_handler)
+  if (ExceptionFilter == &SEHHandler)
     return REAL(SetUnhandledExceptionFilter)(ExceptionFilter);
   // We record the user provided exception handler to be called for all the
   // exceptions unhandled by asan.




More information about the llvm-commits mailing list