[PATCH] D33459: Allow armv7m and armv7em builds

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 17:26:58 PDT 2017


compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

Modulo the IT block macros, LGTM.



================
Comment at: cmake/builtin-config-ix.cmake:27
 set(ARM64 aarch64)
-set(ARM32 arm armhf armv6m)
+set(ARM32 arm armhf armv6m armv7m armv7em)
 set(X86 i386 i686)
----------------
Probably should add `armv7` as well.


================
Comment at: lib/builtins/arm/aeabi_cdcmp.S:103
 #else
+        itt eq
         moveq ip, #0
----------------
We have macros for the IT blocks, can you use those, please?  Similar throughout.


https://reviews.llvm.org/D33459





More information about the llvm-commits mailing list