[PATCH] D33428: [PDB] Hash types up front when merging types instead of using StringMap

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

Drive by comment...



================
Comment at: llvm/trunk/lib/DebugInfo/CodeView/TypeSerializer.cpp:40
+  static inline HashedTypePtr getTombstoneKey() {
+    return HashedTypePtr(reinterpret_cast<HashedType *>(1));
+  }
----------------
This isn't suitably aligned. You should use the DenseMapInfo for some pointer type  instead.


Repository:
  rL LLVM

https://reviews.llvm.org/D33428