[PATCH] D30107: Refactor DynamicLibrary so searching for a symbol will have a defined order and libraries are properly unloaded when llvm_shutdown is called.

Vassil Vassilev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 15:26:39 PDT 2017


v.g.vassilev added a comment.

We are doing an upgrade on our internal vendor drop of LLVM and clang.

This patch causes many failures, preventing us from running llvm without custom patches on top. For instance, the symbol resolution seems to be very different (it cannot find symbols which exist in a shared library). The patch is rather big and I am not sure whether it requires couple of changes or it requires a design change.

I think `cling` and ROOT are one of the major users of this code. @lhames would it make sense to revert this patch? I can confirm this is the only blocker for us to move on and reverting it restores our system into green state.

The author has access to `cling` and ROOT and maybe it would be easier for him to debug it in that context.


Repository:
  rL LLVM

https://reviews.llvm.org/D30107





More information about the llvm-commits mailing list