[PATCH] D33420: [LIR] Strengthen the check for recurrence variable in popcnt/CTLZ

[Evgeny Stupachenko via Phabricator via llvm-commits]

evstupac added a comment.

LGTM.



================
Comment at: lib/Transforms/Scalar/LoopIdiomRecognize.cpp:1140
 
       PHINode *Phi = dyn_cast<PHINode>(Inst->getOperand(0));
       if (!Phi || Phi->getParent() != LoopEntry)
----------------
davide wrote:
> evstupac wrote:
> > Can we reuse the new function here for Inst and Inst->getOperand(0)?
> This is NFC, I assume, but we're technically changing the check. If you don't mind, I would do that in a follow-up.
ok.


https://reviews.llvm.org/D33420