[PATCH] D33458: [git-llvm] Check if svn and git-svn have been installed.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/utils/git-svn/git-llvm:136
 
+def exists(cmd):
+    for path in os.environ["PATH"].split(os.pathsep):
----------------
Maybe call it `program_exists`? `exists` suggests that it is checking for file existence.


================
Comment at: llvm/utils/git-svn/git-llvm:319-320
+        die('error: git-llvm needs svn command, but svn is not installed.')
+    if subprocess.call('git svn --help > /dev/null 2>&1', shell=True) != 0:
+        die('error: "git svn" returns an error. Make sure you have installed git-svn.')
+
----------------
I don't think this script relies on git-svn, so this shouldn't be necessary.


https://reviews.llvm.org/D33458