[PATCH] D33446: [ARM] Temporarily disable globals promotion to constant pools to prevent miscompilation

[Oleg Ranevskyy via Phabricator via llvm-commits]

iid_iunknown added a comment.

In https://reviews.llvm.org/D33446#762242, @efriedma wrote:

> I would suggest switching the option (arm-promote-constant) to default to false rather than commenting out the code, so we don't have to XFAIL the unit-tests.


Thanks for your comment, Eli.

Yes, initially I thought about option adjusting too as it's easier to do, but refused this idea because one might hit the unexpected miscompilation if setting the option to true explicitly in the command line. One will get no warning about possible issues with this option.

Do you confirm that such behavior is acceptable?


Repository:
  rL LLVM

https://reviews.llvm.org/D33446