[PATCH] D33433: [SCEV] Select between two equal values

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 09:18:57 PDT 2017


sanjoy requested changes to this revision.
sanjoy added a comment.
This revision now requires changes to proceed.

I'm not convinced SCEV is the best place to handle this -- by the time IR hits SCEV `select A, B, B` should already have been simplified to `B`.  We do not handle "simple" patterns like `br (xor C, true), label A, label B` for the same reason.

If you *must* do this (and I'm not yet convinced that we must), I'd instead call `SimplifyInstruction` at a higher level (at `createSCEV` perhaps).


https://reviews.llvm.org/D33433





More information about the llvm-commits mailing list