[PATCH] D33248: [Power9] Exploit D-form vector load/store

Zaara Syeda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 08:47:48 PDT 2017


syzaara added inline comments.


================
Comment at: lib/Target/PowerPC/PPCInstrVSX.td:2348
 
   // When adding new D-Form loads/stores, be sure to update the ImmToIdxMap in
   // PPCRegisterInfo::PPCRegisterInfo and maybe save yourself some debugging.
----------------
nemanjai wrote:
> You should probably look into what this is used for. I remember not adding the scalar D-Forms to that map and had very hard to debug problems. But I don't remember how the problems manifested themselves. That's why I added this comment too. I imagine you should probably add yours here as well.
It is already added in the ImmToIdxMap in PPCRegisterInfo::PPCRegisterInfo.


https://reviews.llvm.org/D33248





More information about the llvm-commits mailing list