[PATCH] D33243: [Atomics][LoopIdiom] Recognize unordered atomic memcpy

Daniel Neilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 08:01:50 PDT 2017


dneilson marked an inline comment as done.
dneilson added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopIdiomRecognize.cpp:991
+  // previous checks.
+  if (SI->isAtomic() || LI->isAtomic()) {
+    // element.unordered.atomic is limited to 16-byte element-size because
----------------
skatkov wrote:
> I would prefer to revert the if statement.
> if SI and LI are not atomic then memcpy otherwise your code.
> 
> It is simpler to follow if the short case is handled first.
Sure


https://reviews.llvm.org/D33243





More information about the llvm-commits mailing list