[PATCH] D32740: [PM/Unswitch] Fix a bug in the domtree update logic for the new unswitch pass.

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 22 22:02:38 PDT 2017


davide added a comment.

In https://reviews.llvm.org/D32740#761657, @davide wrote:

> The homegrown dominance frontier logic is not great, but I don't think it's a significant blocker and can be refactored in the future.
>  i.e. I'm much more interested in understanding whether this thing stick together (including the non trivial unswitch, once you get to it).
>  I'm happy with this going in when Danny/Sanjoy are.


To clarify, I'm not talking about the code per-se, which I think is good. I mean that we have two pieces of code which could be shared but currently are not.


https://reviews.llvm.org/D32740





More information about the llvm-commits mailing list