[PATCH] D33419: BitVector: use iterator_facade

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added inline comments.
This revision is now accepted and ready to land.


================
Comment at: include/llvm/ADT/iterator.h:170-174
+  PointerT operator->() {
+    static_assert(
+        std::is_reference<decltype(
+            static_cast<DerivedT *>(this)->operator*())>::value,
+        "operator-> is defined only on iterators returning a const T&");
----------------
What brought you to adding these static_asserts? Not that they're bad, just curious.


https://reviews.llvm.org/D33419