[PATCH] D33417: Implement various flavors of type merging

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm!



================
Comment at: llvm/test/DebugInfo/PDB/pdbdump-merge-ids-and-types.test:4
+; RUN: llvm-pdbdump merge -pdb=%t.3.pdb %t.1.pdb %t.2.pdb
+; RUN: llvm-pdbdump raw -tpi-records %t.3.pdb | FileCheck -check-prefix=TPI-TYPES %s
+; RUN: llvm-pdbdump raw -tpi-records %t.3.pdb | FileCheck -check-prefix=INTMAIN %s
----------------
This would make the test slightly faster:
  ; RUN: llvm-pdbdump raw -tpi-records %t.3.pdb > %t.tpi
  ; RUN: llvm-pdbdump raw -ipi-records %t.3.pdb > %t.ipi
  ; RUN: FileCheck %s -check-prefix=TPI-TYPES < %t.tpi
  ; RUN: FileCheck %s -check-prefix=INTMAIN < %t.tpi
  ; RUN: FileCheck %s -check-prefix=VOIDMAIN < %t.tpi
  ; RUN: FileCheck %s -check-prefix=IPI-TYPES < %t.ipi
  ; RUN: FileCheck %s -check-prefix=IPI-NAMES< %t.ipi
  ; RUN: FileCheck %s -check-prefix=IPI-UDT< %t.ipi

Up to you. It's probably only worth it for 4+ runs.


https://reviews.llvm.org/D33417