[PATCH] D33180: Add functionality to cvtres to parse all entries in res file.

[Eric Beckmann via llvm-commits]

Ah I see, okay I shall remove that in a future patch.

On Fri, May 19, 2017 at 7:40 PM, Zachary Turner <zturner at google.com> wrote:

>
>
> On Fri, May 19, 2017 at 6:59 PM Eric Beckmann via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> ecbeckmann added inline comments.
>>
>>
>> ================
>> Comment at: llvm/include/llvm/Object/WindowsResource.h:59
>> + public:
>> +  ~WindowsResource() override;
>> +
>> ----------------
>> ruiu wrote:
>> > Do you need this?
>> Yes because the destructor is declared virtual in the base class.
>>
>>
> I think what he meant is that the definition of the function doesn't do
> anything, it's just defined in the cpp file with =default.  So if that's
> the case, you can just delete it here.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170521/5e3de115/attachment.html>