[PATCH] D33376: Revert "Add functionality to cvtres to parse all entries in res file."

Eric Beckmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 21 18:30:03 PDT 2017


ecbeckmann abandoned this revision.
ecbeckmann added a comment.

In https://reviews.llvm.org/D33376#760195, @zturner wrote:

> You don't have to create Phabricator reviews for reverts.  If something is broken on the bots, just push the revert.  When you do, however, two things to keep in mind.
>
> 1. Replace the git hash with the SVN revision of the original commit.
> 2. Add a brief message explaining why it's being reverted.
>
>   That aside, can you expand on #2?  What happened?


Sorry for the lack of explanation.  I was reverting it because it caused certain build bots to break.  The breaks were due to the fact that I define arrays that represent the data stored in the .res file header, however I only ever use those arrays in order to take their size, therefore they were being ignored on some builds and would cause errors.  Fortunately it looks like someone else fixed it and this revert is no longer necessary.


https://reviews.llvm.org/D33376





More information about the llvm-commits mailing list