[PATCH] D33388: [libcxx] fixup bootstrapping for mingw-w64

[Martell Malone via Phabricator via llvm-commits]

martell added inline comments.


================
Comment at: libcxx/trunk/lib/CMakeLists.txt:246
   set(STATIC_OUTPUT_NAME "c++")
-  if (WIN32)
+  if (WIN32 AND NOT MINGW)
     set(STATIC_OUTPUT_NAME "libc++")
----------------
martell wrote:
> chapuni wrote:
> > "MSVC" is available.
> Yes, We can use `MSVC`
> 
> I have a habit of avoiding it because CMAKE is not great in differentiating between the IDE and the compiler but it should work fine here.
> I'm hoping more recent versions detect clang tageting msvc not in cl.exe mode picks that up correctly.
> Good spot btw.
Now that I think about it more, I would like to avoid this.
Will update to just override `CMAKE_STATIC_LIBRARY_PREFIX` to `lib`
We need this to avoid the same name as msvc libc++ I believe.


Repository:
  rL LLVM

https://reviews.llvm.org/D33388