[PATCH] D32833: [Triple] Add method for triple canonicalization

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 20 13:10:29 PDT 2017


rengolin requested changes to this revision.
rengolin added a comment.
This revision now requires changes to proceed.

Right, I think this is a useful thing to have, but it needs a better plan.

To solve your other problem, I recommend implementing there, locally, for fucsia.

The triple handling, both in clang and llvm, is really confusing and broken. We already have one canonicalisation process and it clearly doesn't work for all cases, adding a new one won't help.

After you solve the problem for fucsia, you should go on the list and bring a proposal to have a single canonicalisation process and representation (Daniel Sanders and Simon Dardis were working on one, with Eric Christopher's help).

The biggest problem is that there are too many users of the triple and none of them use quite the same things in the same way.

Once we have a consensus on the list, we should be producing patches. Not before.

cheers,
--renato


Repository:
  rL LLVM

https://reviews.llvm.org/D32833





More information about the llvm-commits mailing list